Use test ([) instead of expr to compare integers.
authorcl349@firebug.cl.cam.ac.uk <cl349@firebug.cl.cam.ac.uk>
Sat, 3 Dec 2005 23:49:51 +0000 (00:49 +0100)
committercl349@firebug.cl.cam.ac.uk <cl349@firebug.cl.cam.ac.uk>
Sat, 3 Dec 2005 23:49:51 +0000 (00:49 +0100)
expr $int1 '<' $int2 seems to be broken on some shells.
Signed-off-by: Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
tools/examples/xen-hotplug-common.sh

index 6a9df2d4d85c3663a22f9a876e43b685bf8beecb..d4ebedf9e725c060e5c1c567bbee9ffe1d31cedc 100644 (file)
@@ -119,7 +119,7 @@ _claim_lock()
   local owner=$(_lock_owner "$lockdir")
   local retries=0
 
-  while expr $retries '<' $LOCK_RETRIES
+  while [ $retries -lt $LOCK_RETRIES ]
   do
     mkdir "$lockdir" && trap "release_lock $1; sigerr" ERR &&
       _update_lock_info "$lockdir" && return
@@ -131,7 +131,7 @@ _claim_lock()
       retries=0
     fi
 
-    if expr $retries '>' $LOCK_SPINNING_RETRIES
+    if [ $retries -gt $LOCK_SPINNING_RETRIES ]
     then
       sleep $LOCK_SLEEPTIME
     else